Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split 'std' feature into 'std' and 'std-fs-io' in casper-types #4445

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

Fraser999
Copy link
Contributor

This PR restricts the functionality of the std feature of casper-types to exclude methods unsuitable when compiling the crate to Wasm. It also adds a std-fs-io feature to include this functionality.

It borrows the concept and supersedes #4348 by @gRoussac.

casper-ecosystem/rustSDK#8
casper-ecosystem/rustSDK#10

Copy link
Contributor

@zacshowa zacshowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gRoussac gRoussac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !!!

@Fraser999
Copy link
Contributor Author

bors merge

Copy link
Contributor

Build succeeded:

@casperlabs-bors-ng casperlabs-bors-ng bot merged commit 8ca9001 into casper-network:dev Dec 18, 2023
3 checks passed
@Fraser999 Fraser999 deleted the rustSDK-1.6 branch December 18, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants